[Download] Size of asset is not visible

[bmalecki]

Feature Request

Is your feature request related to a problem? Please describe.
When an uploaded asset does not contain metadata dam:size (e.g. /content/dam/your-app/example-image.jpg/jcr:content/metadata), size of asset is not visible on Download component.

Describe the solution you'd like
To fix this issue we need to change DownloadImpl code in Core Components Repository (https://github.com/adobe/aem-core-wcm-components/blob/master/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v1/DownloadImpl.java#L209)

from

size = null;
Object rawFileSizeObject = downloadAsset.getMetadata(DamConstants.DAM_SIZE);
if (rawFileSizeObject != null) {
long rawFileSize = (Long) rawFileSizeObject;
size = FileUtils.byteCountToDisplaySize(rawFileSize);
}

to

long rawFileSize = downloadAsset.getOriginal().getSize();
size = FileUtils.byteCountToDisplaySize(rawFileSize);

Are there alternatives?
Another solution to resolve this issue is run "Add asset size" workflow over an asset. This workflow adds dam:size metadata to assets.

[msagolj]

@bmalecki thank for your change request. Your suggestion looks good to me. Not sure how much slower it is then just checking the DAM property, as its is trying to access the binary to get the size.

Maybe better to first try dam:size and if null , go for .getOriginal().getSize(). ? Would you be OK to post your solution as a PR to the development branch so it gets reviewed/merged ?

[joerghoh]

We should be careful here, as unintentionally you might end up with loading the underlying asset from the datastore, just to determine its size. While in many cases (especially with a local datastore) this is not a problem, it can be very problematic when you work with a S3 datastore.

[andreeadracea]

The problem was solved.

[richardhand]

The code for this issue is merged to master and will be available in the upcoming 2.8.0 release.