replace @Inject annotation with the specific ones #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
reviewed
Feb 4, 2023
...e/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v1/ClientLibrariesImpl.java
Outdated
Show resolved
Hide resolved
bpauli
approved these changes
Feb 9, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
=========================================
Coverage 87.34% 87.34%
Complexity 2648 2648
=========================================
Files 232 232
Lines 7080 7080
Branches 1073 1073
=========================================
Hits 6184 6184
Misses 359 359
Partials 537 537 ☔ View full report in Codecov by Sentry. |
|
@bpauli done. |
bpauli
approved these changes
Feb 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
bpauli
added
enhancement
|
Kudos, SonarCloud Quality Gate passed!
|
…o improvement/remove-inject-annotations
|
vladbailescu
added a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of the
@Injectannotation and replace it with the more specific injector-specific one.