Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITES-15335 - handle id empty values input #2571

Merged
merged 1 commit into from
Aug 16, 2023
Merged

SITES-15335 - handle id empty values input #2571

merged 1 commit into from
Aug 16, 2023

Conversation

cbogdan0707
Copy link
Contributor

@cbogdan0707 cbogdan0707 commented Aug 14, 2023 •
edited by LSantha
Loading

Q                       A
Fixed Issues? SITES-15335
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #2571 (f3aae84) into main (55a083f) will not change coverage.
The diff coverage is n/a.

❗ Current head f3aae84 differs from pull request most recent head 466271f. Consider uploading reports for the commit 466271f to get more accurate results

@@            Coverage Diff            @@
##               main    #2571   +/-   ##
=========================================
  Coverage     87.33%   87.33%           
  Complexity     2646     2646           
=========================================
  Files           232      232           
  Lines          7072     7072           
  Branches       1071     1071           
=========================================
  Hits           6176     6176           
  Misses          359      359           
  Partials        537      537

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cbogdan0707 cbogdan0707 merged commit 603bf36 into main Aug 16, 2023
15 checks passed
@cbogdan0707 cbogdan0707 deleted the 15335 branch August 16, 2023 10:06
@vladbailescu vladbailescu added this to the 2.23.4 milestone Sep 12, 2023
@LSantha LSantha changed the title SITES-15335: handle id empty values input SITES-15335 - handle id empty values input Sep 13, 2023
@vladbailescu vladbailescu linked an issue Jan 16, 2024 that may be closed by this pull request
HTML ID Validation - The validator should not throw error when ID field is empty #2522
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbailescu vladbailescu vladbailescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.4
Development

Successfully merging this pull request may close these issues.

HTML ID Validation - The validator should not throw error when ID field is empty
2 participants
@cbogdan0707 @vladbailescu