Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2611] Fixed Non-deterministic behavior of Class.getDeclaredFields() that might fail test in EmbedUrlProcessorServletTest #2630

Conversation

SaaiVenkat
Copy link
Contributor

Q A
Fixed Issues? Fixes #2611
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Tests Pass
Documentation Provided No
Any Dependency Changes? No
License Apache License, Version 2.0
  • This fix implements the 1st proposed solution mentioned in the issue.
  • The json strings to be compared are converted to JsonNode using ObjectMapper.
  • Comparing with JsonNodes instead of hardcoded strings make sure the correct key value pair are present, even though the order of keys might change.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14e70e3) 87.34% compared to head (6224230) 87.34%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2630   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7080     7080           
  Branches       1073     1073           
=========================================
  Hits           6184     6184           
  Misses          359      359           
  Partials        537      537           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladbailescu vladbailescu merged commit ee6ce24 into adobe:main Dec 27, 2023
10 checks passed
@LSantha LSantha added this to the 2.24.0 milestone Feb 14, 2024
@SaaiVenkat SaaiVenkat deleted the improvement/fix-flaky-testUrlWithRegisteredProvidertest branch October 1, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants