SITES-18137: core.wcm.components.core: remove non-test use of Guava #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced usages of Guava with JavaSE and Apache Commons.
bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v2/ImageImpl.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/adobe/cq/wcm/core/components/internal/servlets/AdaptiveImageServlet.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
============================================
+ Coverage 87.34% 87.36% +0.02%
- Complexity 2648 2656 +8
============================================
Files 232 232
Lines 7080 7101 +21
Branches 1073 1081 +8
============================================
+ Hits 6184 6204 +20
+ Misses 359 357 -2
- Partials 537 540 +3 ☔ View full report in Codecov by Sentry. |
Addressed change request by @vladbailescu
Created new utility method imitating the bevavior of com.google.common.net.URL_FRAGMENT_ESCAPER
|
vladbailescu
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2639
Added compile dependency to core.wcm.components.core: org.apache.commons:commons-collections4-4.4
Replaced non-test usages of Guava with JavaSE and Apache Commons.