[SITES-22335] fix e2e tests for 6.5 and SDK #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YahorC
commented
Jul 30, 2024
YahorC
commented
| Q | A |
|---|---|
| Fixed Issues? | https://jira.corp.adobe.com/browse/SITES-22335 |
| Patch: Bug Fix? | |
| Minor: New Feature? | |
| Major: Breaking Change? | |
| Tests Added + Pass? | Yes |
| Documentation Provided | Yes (code comments and or markdown) |
| Any Dependency Changes? | |
| License | Apache License, Version 2.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2826 +/- ##
=========================================
Coverage 87.21% 87.21%
Complexity 2690 2690
=========================================
Files 235 235
Lines 7173 7173
Branches 1096 1096
=========================================
Hits 6256 6256
Misses 363 363
Partials 554 554 ☔ View full report in Codecov by Sentry. |
myronenko
reviewed
Jul 31, 2024
| @@ -88,6 +89,11 @@ public void setDescription(String value) { | |||
| $(description).sendKeys(value); | |||
| } | |||
|
|
|||
| public void setALTText(String value) { | |||
There was a problem hiding this comment.
camelCase
Suggested change
| public void setALTText(String value) { | |
| public void setAltText(String value) { |
myronenko
reviewed
Jul 31, 2024
| @@ -433,6 +433,7 @@ public void testNoImageTeaser() throws TimeoutException, InterruptedException { | |||
| assertEquals(editDialog.getAssetWithoutDescriptionErrorMessage(), "Error: Please provide an asset which has a description that can be used as alt text."); | |||
| editDialog.checkImageFromPageImage(); | |||
| editDialog.checkAltTextFromAssetDescription(); | |||
| editDialog.setALTText("alt"); | |||
There was a problem hiding this comment.
camelCase
Suggested change
| editDialog.setALTText("alt"); | |
| editDialog.setAltText("alt"); |
myronenko
approved these changes
Jul 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.