Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITES-3659 - [Odin] Review Dispatcher config for Odin and contribute generic parts - Persisted queries #369

Merged
merged 1 commit into from
Jul 12, 2022
Merged

SITES-3659 - [Odin] Review Dispatcher config for Odin and contribute generic parts - Persisted queries #369

merged 1 commit into from
Jul 12, 2022

Conversation

sandru85
Copy link
Member

@sandru85 sandru85 commented Jul 12, 2022 •
edited
Loading

GraphQL persisted queries should be cached by default at dispatcher level.

Description

The query parameters sent in the request via dispatcher need to be encoded. One example of such query is
https://publish-p33706-e135212.adobeaemcloud.com/graphql/execute.json/aem-cplotusonlinecommerce-project/getMarketingBannersList%3Btag%3Dmarketing-banner-homepage%3Bpath%3D%2Fcontent%2Fdam%2Faem-cplotusonlinecommerce-project%2Fth%2Fen%2Fhome

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sandru85
Copy link
Member Author

sandru85 commented Jul 12, 2022 •
edited
Loading

@godanny86 or @keepthebyte can you please merge this one? it has been merged to https://git.corp.adobe.com/Granite/dispatcher-k8s-base/pull/177 and adobe/aem-project-archetype#946

@keepthebyte
Copy link
Collaborator

@davidjgonzalez should be able to merge it.

@SachinMali SachinMali merged commit edce55c into adobe:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandru85 @keepthebyte @SachinMali