Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified CORS Dispatcher configuration #419

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

davidjgonzalez
Copy link
Contributor

Simplified CORS configuration by removing ENABLE_CORS variable. The enabling of CORS in Dispatcher is implicit via the addition of the CORS section in the vhost.

Motivation and Context

Simplify the CORS Dispatcher configuration.

How Has This Been Tested?

AEM SDK Dispatcher Tools validator, and RDE.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davidjgonzalez davidjgonzalez marked this pull request as ready for review August 10, 2023 16:06
@SachinMali SachinMali merged commit dc88671 into main Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants