Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete destructuring in decorate.js::decorateIcons #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flx-sta
Copy link

@flx-sta flx-sta commented Feb 8, 2024

remove obsolete destructuring in decorate.js::decorateIcons

Description

The destructuring here is unnecessary cause a NodeList, which is the return type for querySelectorAll supports forEach too and we also don't have to get rid of any references.

Related Issue

#40

Motivation and Context

is eliminates obsolete code

How Has This Been Tested?

By removing it in local development and everything still works fine

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

remove obsolete destructuring
@flx-sta
Copy link
Author

flx-sta commented Apr 9, 2024

push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants