Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cq 4348367 new #1031

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Cq 4348367 new #1031

merged 4 commits into from
Jan 30, 2023

Conversation

barshat7
Copy link
Contributor

Description

  • Include package-lock.json for af headless
  • Update NPM and Node Version for af headless
  • Separate Page Component for Adaptive Forms

Related Issue

CQ-4348367

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

rismehta
rismehta approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barshat7 barshat7 added this to the 40 milestone Jan 27, 2023
@rismehta rismehta merged commit af843ea into develop Jan 30, 2023
@rismehta rismehta deleted the CQ-4348367_New branch January 30, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rismehta rismehta rismehta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
40
Development

Successfully merging this pull request may close these issues.
2 participants
@barshat7 @rismehta