Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CQ-4352179: update npm references to fix local testing issues on M1-based machines #1044

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

bisswanger
Copy link
Contributor

@bisswanger bisswanger commented Feb 14, 2023

Description

Due to SeleniumHQ/selenium#11066, users running local testing on M1-based machines failed test execution.
This was fixed in https://github.com/webdriverio/selenium-standalone/releases/tag/v8.2.1.
This PR is updating package-lock.json from npm update selenium-standalone to get the dependency updated

Related Issue

CQ-4352179

Motivation and Context

Bug fix, support local testing on M1 machines

How Has This Been Tested?

  • Local testing on M1 machine
  • Local testing on x64-machine
  • Testing via test image + AEMaaCS testing service

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vladbailescu vladbailescu merged commit 13ab85c into adobe:develop Feb 15, 2023
@barshat7 barshat7 added this to the 41 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants