Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms 3632 #1047

Merged
merged 14 commits into from
Mar 2, 2023
Merged

Forms 3632 #1047

merged 14 commits into from
Mar 2, 2023

Conversation

barshat7
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@barshat7 barshat7 requested a review from rismehta February 27, 2023 05:24
@@ -216,7 +216,7 @@ if (includeFormsheadless == "n") {
}

// if forms is included and aem version is set to cloud, set the forms sdk version
if ((includeForms == "y" || includeFormsenrollment == "y" || includeFormscommunications == "y" || includeFormsheadless == "y") && aemVersion == "cloud") {
if (includeForms == "y" || includeFormsenrollment == "y" || includeFormscommunications == "y" || includeFormsheadless == "y") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the forms SDK for 6.5 ?

@rismehta
Copy link
Contributor

Can you also update the template content for the proxy form container component ?

Copy link
Contributor

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments

Copy link
Contributor

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barshat7 barshat7 added this to the 41 milestone Mar 1, 2023
@rismehta rismehta merged commit 4f891d4 into develop Mar 2, 2023
@rismehta rismehta deleted the FORMS-3632 branch March 2, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants