Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove header in page-content template if no commerce project #726

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

bpauli
Copy link
Contributor

@bpauli bpauli commented May 27, 2021

Requesting a page for a project which is not a commerce project produces the following error in the log

27.05.2021 17:02:03.991 *ERROR* [[0:0:0:0:0:0:0:1] [1622127723796] GET /content/project/us/en.html HTTP/1.1] org.apache.sling.servlets.get.impl.DefaultGetServlet No renderer for extension html, cannot render resource JcrNodeResource, type=nt:folder, superType=null, path=/conf/project/settings/wcm/templates/page-content/structure/jcr:content/root/header
27.05.2021 17:02

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bpauli bpauli requested a review from LSantha May 27, 2021 15:37
@barshat7 barshat7 modified the milestone: 37 Jun 14, 2022
@vladbailescu vladbailescu merged commit c37915b into develop Jul 18, 2022
@vladbailescu vladbailescu deleted the issue/remove-header branch July 18, 2022 10:48
@vladbailescu vladbailescu added this to the 39 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants