Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to add moment npm dependency that fails on Mac OS #905

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

marcovlara
Copy link
Contributor

@marcovlara marcovlara commented Mar 10, 2022

Update package.json to add moment npm dependency that fails on Mac OS.

This issue was reported on #891

npm was complaining on a dependency: [INFO] Error: Cannot find module 'moment'

Description

Added the latest moment npm dependency under the /ui.tests/test-module/package.json

"moment": "^2.29.1"

Related Issue

#891

Motivation and Context

build failed when executing the tests when running the command: mvn verify -Pui-tests-local-execution

How Has This Been Tested?

Tested this locally on two Macs

Screenshots (if appropriate):

Screen Shot 2022-03-10 at 12 42 41 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Update package.json to add moment npm dependency that fails on Mac OS.

This issue was reported on adobe#891
@stefanseifert
Copy link
Contributor

same problem on windows - the ui.tests are failing both locally and inside docker image without this dependency.
i've validated that this PR fixes the problem.

@vladbailescu vladbailescu merged commit 6cfc897 into adobe:develop Jul 15, 2022
@vladbailescu vladbailescu linked an issue Sep 27, 2022 that may be closed by this pull request
@vladbailescu vladbailescu added this to the 39 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues executing UI Tests on v33+
4 participants