Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for parallel process not working on windows #941

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2022

Parallel using ampersand is not supported on windows.
npm-run-all enables windows to run watch properly.
Additionally, as requested per adobe/aem-guides-wknd#343
The changes should be implemented in archetype

Description

Parallel processing using ampersands is not supported on Windows platform.
Therefore npm run watch fails to run properly on windows.

Related Issue

Motivation and Context

Following the WKND tutorial and running across this problem has hindered mine and my colleagues progress.
We came up with this solution.

How Has This Been Tested?

We tested it on Windows and Linux and it seems to perform as expected.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

prupra and others added 2 commits June 10, 2022 13:49
Parallel using ampersand is not supported on windows.
npm-run-all enables windows to run watch properly.
The script to start the webpack dev server is called `start`, not `dev`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant