This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Add support for code splitting and static assets #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@grubyak Yeah, it's not working yet because it builds on the code of the currently unreleased PRs. Once they're released, we can update the dependencies and the tests should pass :) |
grubyak
approved these changes
Oct 14, 2019
|
|
* `react-scripts` v3.2 includes the "entrypoints" asset manifest key * The `aem-clientlib-generator` branch includes the required "ignore" options
|
wcm-io-frontend/aem-clientlib-generator#23 has also been merged and released, so this PR can now be reviewed :) |
grubyak
approved these changes
Oct 30, 2019
habansal
reviewed
Nov 1, 2019
habansal
approved these changes
Nov 1, 2019
habansal
approved these changes
Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the newly added doc files for a description of the changes.
Requires facebook/create-react-app#7721 and wcm-io-frontend/aem-clientlib-generator#23 to be merged and released first.