Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-7941: delegate PageImpl#getHtmlPageItems() #60

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Nov 8, 2022

Description

In order to support the frontend pipeline we have to render the html page items configured in a context aware configuration to the page head/footer. This is done already in inherited head and footer htl templates. However the Page model needs to expose those configurations to the template which is not the case yet.

Related Issue

SITES-7941

Motivation and Context

Add an example of a decoupled frontend build SPA project to the aem-project-archetype.

How Has This Been Tested?

Locally and with unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #60 (4867dc3) into master (7cb8108) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
+ Coverage     81.13%   81.22%   +0.08%     
- Complexity       98       99       +1     
============================================
  Files            11       11              
  Lines           212      213       +1     
  Branches         32       32              
============================================
+ Hits            172      173       +1     
  Misses           22       22              
  Partials         18       18              
Impacted Files Coverage Δ
...e/aem/spa/project/core/internal/impl/PageImpl.java 78.26% <100.00%> (+0.48%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants