Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a maven mojo to validate OSGi configurations #178 #179

Merged
merged 10 commits into from
Oct 12, 2022
Merged

Add a maven mojo to validate OSGi configurations #178 #179

merged 10 commits into from
Oct 12, 2022

Conversation

cziegeler
Copy link
Contributor

@cziegeler cziegeler commented Oct 10, 2022

This adds a new mojo to directly validate OSGi configurations inside a project

Description

The mojo allows to scan an expanded repository directory on disk, finds the OSGi configurations and then validates them.

The PR looks large, however the changes to the mojos are minimal:

  • some functionality is moved to an abstract mojo class for reuse in different mojos
  • new AnalyseConfigsMojo for the new functionality
  • core gets a new package with the actual implementation of validating OSGi configurations in a project. This makes the code usable outside of maven
  • a new prototype of a cli using above core code. this cli can be run without maven

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bosschaert
Copy link
Contributor

Hi @cziegeler looks great to me. One suggestion - I see that the new cli doesn't have any unit tests at all. Would it be possible to get some coverage there?

@cziegeler
Copy link
Contributor Author

Thanks @bosschaert - I've just added a test which tests most of the new code - except for the new third module which I think needs some more love anyway

Copy link
Contributor

@bosschaert bosschaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cziegeler LGTM 👍

@cziegeler cziegeler merged commit 7fbc235 into adobe:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants