Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the 2.0 version of the feature model artifacts #197

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Update to the 2.0 version of the feature model artifacts #197

merged 3 commits into from
Feb 13, 2023

Conversation

rombert
Copy link
Contributor

@rombert rombert commented Feb 6, 2023

Description

Update to the 2.0 version of the feature model artifacts

Related Issue

Motivation and Context

Keeping up with the latest dependencies.

How Has This Been Tested?

mvn clean install

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rombert
Copy link
Contributor Author

rombert commented Feb 6, 2023

Draft until the releases are actually out.

@rombert rombert marked this pull request as ready for review February 13, 2023 10:24
cziegeler
cziegeler approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@cziegeler cziegeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

@rombert rombert merged commit 84d106d into main Feb 13, 2023
@rombert rombert deleted the issue/update-feature-model-2.0 branch February 13, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cziegeler cziegeler cziegeler approved these changes

@bosschaert bosschaert Awaiting requested review from bosschaert

@karlpauls karlpauls Awaiting requested review from karlpauls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rombert @cziegeler