Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions reusable workflows #47

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

timkimadobe
Copy link
Contributor

@timkimadobe timkimadobe commented Jan 24, 2025

Description

This PR migrates the repo to use the reusable workflows (tag version: gha-android-3.3.0) from aepsdk-commons for:

  • Update versions
    • Removal of local version scripts
  • Release
  • Snapshot
  • Build and test
    • Migrating CircleCI -> GitHub Actions

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (da55d63) to head (6a96aa1).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #47      +/-   ##
============================================
+ Coverage     85.23%   86.33%   +1.10%     
  Complexity      144      144              
============================================
  Files             6        6              
  Lines           616      651      +35     
  Branches         92       96       +4     
============================================
+ Hits            525      562      +37     
+ Misses           56       54       -2     
  Partials         35       35              
Flag Coverage Δ
android-functional-tests 64.36% <ø> (?)
android-unit-tests 82.80% <ø> (?)
functional-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

.github/workflows/build-and-test.yml Show resolved Hide resolved
@@ -31,7 +31,8 @@ checkformat:
format-license:
(./code/gradlew -p code licenseFormat)

lint:
# Used by build and test CI workflow
lint: checkformat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the lint checks are more than just code formatting, there may be times when one needs to be run without the other. Could we not add checkformat as a dependency to lint and instead call each separately in CI? I think it would also make the CI scripts easier to understand in terms of what each step does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did have them separately initially in the build-and-test workflow but Edge vs all the other extension repos use different commands, so I wanted to create a single unified lint command that the CI relies on and each repo can set up whichever lint related checks they want

initially it had the ci- prefix but because the command wasn't necessarily CI exclusive, it was removed in favor of just make lint

What do you think?

@timkimadobe timkimadobe requested a review from kevinlind February 1, 2025 00:18
@timkimadobe timkimadobe merged commit aa86290 into adobe:main Feb 5, 2025
12 of 13 checks passed
@timkimadobe timkimadobe mentioned this pull request Feb 5, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants