-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions reusable workflows #47
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
============================================
+ Coverage 85.23% 86.33% +1.10%
Complexity 144 144
============================================
Files 6 6
Lines 616 651 +35
Branches 92 96 +4
============================================
+ Hits 525 562 +37
+ Misses 56 54 -2
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -31,7 +31,8 @@ checkformat: | |||
format-license: | |||
(./code/gradlew -p code licenseFormat) | |||
|
|||
lint: | |||
# Used by build and test CI workflow | |||
lint: checkformat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the lint checks are more than just code formatting, there may be times when one needs to be run without the other. Could we not add checkformat
as a dependency to lint
and instead call each separately in CI? I think it would also make the CI scripts easier to understand in terms of what each step does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did have them separately initially in the build-and-test workflow but Edge vs all the other extension repos use different commands, so I wanted to create a single unified lint command that the CI relies on and each repo can set up whichever lint related checks they want
- Unified lint command using
ci-lint
: Android custom build and test workflow artifact upload support aepsdk-commons#109
initially it had the ci-
prefix but because the command wasn't necessarily CI exclusive, it was removed in favor of just make lint
ci-
prefix removal: Add template regex support for primary extension in version workflows aepsdk-commons#110
What do you think?
Description
This PR migrates the repo to use the reusable workflows (tag version:
gha-android-3.3.0
) from aepsdk-commons for:Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: