Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all runner versions to explicit version instead of latest #108

Merged
merged 10 commits into from
Jan 28, 2025

Conversation

timkimadobe
Copy link
Contributor

@timkimadobe timkimadobe commented Jan 24, 2025

Description

Note

This bumps the patch version of both iOS and Android workflows.
Android: 3.1.0 -> 3.1.1
iOS: 5.0.0 -> 5.0.1

This PR:

  • Updates all runner versions for reusable workflows to use explicit versions instead of latest.
    • This is to avoid similar issues in the future where breaking changes in the latest runner are not automatically picked up by critical workflows like PR CI/CD, release, etc.
  • Fixes Android emulator issue by updating Android emulator action version to latest for compatibility with ubuntu-24.04
  • Addresses breaking change for GitHub actions/cache version deprecation by upgrading usages to latest version v4.2.0

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe timkimadobe merged commit 525de3c into adobe:main Jan 28, 2025
2 checks passed
@timkimadobe timkimadobe deleted the fix-runner-versions branch January 28, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants