Testing implementation for supporting advertising identifier #56

timkimadobe · 2022-03-18T21:14:52Z

Description

Updating test cases to cover ad ID related feature updates.
IdentityState: with consent event dispatch, without consent event dispatch, no update to ad ID
IdentityProperties: get/set ad ID tests

Add tests for ad ID getter and setter Add tests for event utils ad ID helpers Add tests for ad ID event flow (e2e) Rename ad ID event utils methods to match naming conventions

# Conflicts: # code/edgeidentity/src/main/java/com/adobe/marketing/mobile/edge/identity/EventUtils.java # code/edgeidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityExtensionTests.java

# Conflicts: # code/edgeidentity/src/main/java/com/adobe/marketing/mobile/edge/identity/IdentityState.java

…e/aepsdk-edgeidentity-android into feature-ad-id-testing

codecov · 2022-03-18T21:20:30Z

Codecov Report

Merging #56 (e017ad4) into feature/adIdConsent (3b43391) will increase coverage by 26.51%.
The diff coverage is 91.84%.

@@                   Coverage Diff                    @@
##           feature/adIdConsent      #56       +/-   ##
========================================================
+ Coverage                54.51%   81.02%   +26.51%     
========================================================
  Files                       19       19               
  Lines                      910      922       +12     
  Branches                   138      140        +2     
========================================================
+ Hits                       496      747      +251     
+ Misses                     322      123      -199     
+ Partials                    92       52       -40

Flag	Coverage Δ
functional-tests	`61.17% <81.63%> (+6.67%)`	⬆️
unit-tests	`79.06% <89.80%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../edge/identity/ListenerIdentityRequestContent.java	`94.12% <ø> (+82.35%)`	⬆️
.../marketing/mobile/edge/identity/IdentityState.java	`89.32% <85.71%> (+37.36%)`	⬆️
...obe/marketing/mobile/edge/identity/EventUtils.java	`67.44% <100.00%> (+29.94%)`	⬆️
...keting/mobile/edge/identity/IdentityExtension.java	`74.31% <100.00%> (+11.55%)`	⬆️
...eting/mobile/edge/identity/IdentityProperties.java	`89.87% <100.00%> (+29.06%)`	⬆️
...keting/mobile/edge/identity/IdentityConstants.java	`0.00% <0.00%> (ø)`
...e/marketing/mobile/edge/identity/IdentityItem.java	`60.87% <0.00%> (+13.04%)`	⬆️
... and 13 more

code/edgeidentity/src/main/java/com/adobe/marketing/mobile/edge/identity/IdentityState.java

code/edgeidentity/src/main/java/com/adobe/marketing/mobile/edge/identity/EventUtils.java

...eidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityExtensionTests.java

.../edgeidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityStateTests.java

…onsent event data format and values

…nction

code/edgeidentity/src/main/java/com/adobe/marketing/mobile/edge/identity/EventUtils.java

code/edgeidentity/src/main/java/com/adobe/marketing/mobile/edge/identity/IdentityState.java

.../edgeidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityStateTests.java

...identity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityPropertiesTests.java

code/edgeidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/EventUtilsTests.java

Update IdentityStateTest case to test for null ad ID on IdentityState initialization Update log formatting

…ID value in props Update test names to match naming convention

…in ad ID event data Update test file formatting for EventUtilsTests Update EventUtils method locations to be grouped by method function and ordered by method name

… call sites

timkimadobe

Updated test classes based on feedback; all zeros -> all zeros case still needs some review

.../edgeidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityStateTests.java

emdobrin · 2022-03-23T17:01:44Z

The changes look good, and let's add a few additional functional tests for integration testing with MobileCore.

…er helper and junit functions

tests calling mobile core API to set advertising identifier and verifies: - event dispatch - value in persistence - value in XDM shared state

Remove test case for impossible initial state of all zeros ad ID

Update functional test with javadocs, cleaned up test case comments and descriptions

emdobrin

Looks good to me, left a small comment about a duplicated test.

...identity/src/androidTest/java/com/adobe/marketing/mobile/edge/identity/IdentityAdIdTest.java

timkimadobe added 11 commits March 14, 2022 14:39

Test cases for IdentityState (with consent, without consent, no change)

2781306

Add tests for request content listener

1859581

Add tests for ad ID getter and setter Add tests for event utils ad ID helpers Add tests for ad ID event flow (e2e) Rename ad ID event utils methods to match naming conventions

Updating javadocs

6bd8331

Merge branch 'feature-ad-id' into feature-ad-id-testing

5485166

# Conflicts: # code/edgeidentity/src/main/java/com/adobe/marketing/mobile/edge/identity/EventUtils.java # code/edgeidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityExtensionTests.java

Update tests to use new signature for updateAdvertisingIdentifier

14ac3b4

Merge branch 'feature-ad-id' into feature-ad-id-testing

1de27c7

# Conflicts: # code/edgeidentity/src/main/java/com/adobe/marketing/mobile/edge/identity/IdentityState.java

Test cases for IdentityState (with consent, without consent, no change)

f2ae0b5

Rebase testing branch to ad ID feature branch

d410403

Updating javadocs

89659ff

Update tests to use new signature for updateAdvertisingIdentifier

026a8bf

Merge branch 'feature-ad-id-testing' of https://github.com/timkimadob…

9759f2f

…e/aepsdk-edgeidentity-android into feature-ad-id-testing

timkimadobe requested review from kevinlind and emdobrin March 18, 2022 22:09

kevinlind reviewed Mar 18, 2022

View reviewed changes

timkimadobe added 6 commits March 18, 2022 15:51

Removing outdated comment

582b335

Update javadoc style to use proper format

e2fe056

Update try/catch for getAdId to be variable only

86df525

Update test_handleRequestContent_processesWhenBooted case to verify c…

cce1f86

…onsent event data format and values

Remove unneeded commented mock

cc35bc0

Extract repetitive flat identity map verification into test helper fu…

dcd23ab

…nction

emdobrin reviewed Mar 19, 2022

View reviewed changes

timkimadobe added 7 commits March 21, 2022 16:51

Add log message for ClassCastException in getAdId helper method

18afe28

Move private helper functions to bottom of file

b6b2f10

Update IdentityStateTest case to test for null ad ID on IdentityState initialization Update log formatting

Update test case to cover the valid -> null case

076a10a

Update Update XDM ad ID test cases to check against actual stored ad …

f9a21b6

…ID value in props Update test names to match naming convention

Update EventUtilsTests to include new test case for unexpected types …

d901238

…in ad ID event data Update test file formatting for EventUtilsTests Update EventUtils method locations to be grouped by method function and ordered by method name

Update test helper access level to private in IdentityStateTests

75a4582

Update IdentityStateTests to use consolidated helper class and update…

3c3bf4d

… call sites

timkimadobe commented Mar 22, 2022

View reviewed changes

emdobrin reviewed Mar 23, 2022

View reviewed changes

.../edgeidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityStateTests.java Outdated Show resolved Hide resolved

.../edgeidentity/src/test/java/com/adobe/marketing/mobile/edge/identity/IdentityStateTests.java Outdated Show resolved Hide resolved

timkimadobe added 5 commits April 8, 2022 14:24

Refactor helper signature for verifyFlatIdentityMap to align with oth…

c8ae966

…er helper and junit functions

Functional test cases for ad ID implementation

297be4e

tests calling mobile core API to set advertising identifier and verifies: - event dispatch - value in persistence - value in XDM shared state

Add functional test case for sending all zeros ad ID twice

440ef0e

Remove test case for impossible initial state of all zeros ad ID

Add test cases for non-ad ID generic identity + request content event

33adc38

Update functional test with javadocs, cleaned up test case comments and descriptions

Update test case description

d07ca21

emdobrin approved these changes Apr 12, 2022

View reviewed changes

...identity/src/androidTest/java/com/adobe/marketing/mobile/edge/identity/IdentityAdIdTest.java Outdated Show resolved Hide resolved

Remove duplicate test case

e017ad4

timkimadobe merged commit 8f79711 into adobe:feature/adIdConsent Apr 12, 2022

timkimadobe deleted the feature-ad-id-testing branch January 18, 2023 23:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Testing implementation for supporting advertising identifier #56

Testing implementation for supporting advertising identifier #56

timkimadobe commented Mar 18, 2022

codecov bot commented Mar 18, 2022 •

edited

Loading

timkimadobe left a comment

emdobrin commented Mar 23, 2022

emdobrin left a comment

Testing implementation for supporting advertising identifier #56

Testing implementation for supporting advertising identifier #56

Conversation

timkimadobe commented Mar 18, 2022

Description

codecov bot commented Mar 18, 2022 • edited Loading

Codecov Report

timkimadobe left a comment

Choose a reason for hiding this comment

emdobrin commented Mar 23, 2022

emdobrin left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 18, 2022 •

edited

Loading