Content Card Container UI Component #538
Open
+165
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsoffiantini
force-pushed
the
content-card-containers
branch
7 times, most recently
from
81521eb to
00e7269
Compare
added 2 commits
October 6, 2025 11:31
…content-card-containers
…content-card-containers
dsoffiantini
requested changes
Oct 6, 2025
| import { Text, View } from "react-native"; | ||
|
|
||
| function UnreadIcon() { | ||
| function UnreadIcon({ placement, image }: { placement: string|undefined, image: { url: string; darkUrl?: string | undefined; } | undefined }) { |
There was a problem hiding this comment.
I think Calise is doing this component
There was a problem hiding this comment.
This is just placeholder
| const { content, error, isLoading } = useContentCardUI(surface); | ||
|
|
||
| const scheme = useColorScheme(); | ||
| const headingColor = Platform.OS === 'ios' |
There was a problem hiding this comment.
this os condition returns the same either way
| const { heading, layout, emptyStateSettings, unread_indicator, isUnreadEnabled } = contentSettings; | ||
|
|
||
| // Derived flags used across renders | ||
| const isHorizontal = layout?.orientation === 'horizontal'; |
There was a problem hiding this comment.
these should all be memoized
| const styles = StyleSheet.create({ | ||
| contentContainer: { | ||
| flex: 1, | ||
| minHeight: 140, |
There was a problem hiding this comment.
i would not used defined heights/widths here or the other styles. Let the content dictate it or the user
| data={content as T[]} | ||
| contentContainerStyle={[styles.contentContainer, contentContainerStyle]} | ||
| horizontal={settings?.content?.layout?.orientation === "horizontal"} | ||
| ItemSeparatorComponent={() => ( |
There was a problem hiding this comment.
We dont need a separator component. The user can add one if theyd like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Content Card Container UI Component
Description
Related Issue
https://jira.corp.adobe.com/browse/MOB-24117
Screenshots (if appropriate):
Vertical Layout (w/o Unread Background Color):
Screen.Recording.2025-10-03.at.4.11.23.PM.mov
Horizontal Layout (w/ Unread Background Color):
Screen.Recording.2025-10-03.at.4.06.08.PM.mov
Types of changes
Checklist: