Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for add services #11

Merged
merged 47 commits into from
Jan 22, 2021
Merged

Support for add services #11

merged 47 commits into from
Jan 22, 2021

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Nov 19, 2020

Description

features

  • select and add services on init when workspace is new
  • create private/public keys and store them locally
  • support clone services from another workspace when workspace is new and project is not
  • add services to prod and stage workspace when project is new

refactoring

  • flesh out LibConsoleCLI that will be reused in aio-cli-plugin-app

testing

  • reusable data mocks

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho marked this pull request as ready for review December 22, 2020 15:17
@moritzraho moritzraho changed the title [WIP] Enable add services Support for add services Dec 22, 2020
@moritzraho moritzraho requested a review from shazron January 6, 2021 11:27
@moritzraho moritzraho closed this Jan 8, 2021
@moritzraho moritzraho reopened this Jan 8, 2021
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #11 (dcefc16) into master (276c461) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #11    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            4         6     +2     
  Lines          163       434   +271     
  Branches        18        54    +36     
==========================================
+ Hits           163       434   +271     
Impacted Files Coverage Δ
generators/app/index.js 100.00% <100.00%> (ø)
lib/console-cli.js 100.00% <100.00%> (ø)
lib/prompt.js 100.00% <100.00%> (ø)
lib/pure-helpers.js 100.00% <100.00%> (ø)
lib/validate.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276c461...dcefc16. Read the comment docs.

test/lib/pure-helpers.test.js Outdated Show resolved Hide resolved
@moritzraho
Copy link
Member Author

@shazron somehow the first flatmap change I did got lost in a merge, anyway this is ready again to be reviewed, all tests pass

@moritzraho moritzraho merged commit 4282de1 into master Jan 22, 2021
@moritzraho moritzraho deleted the enable-add-services branch January 22, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants