Update publish-to-npm workflow to accommodate alpha and beta packages #126
Conversation
| version_tag="latest" | ||
|
|
||
| elif [ "$target_branch" == "develop" ]; then | ||
| if [[ "${{ steps.get_version.outputs.version }}" =~ beta ]]; then |
There was a problem hiding this comment.
I am new to this, so can you confirm if this is checking for beta in the version string from get_version step?
There was a problem hiding this comment.
I dont think we should move forward with publishing if the version string does not have beta in case of merge to develop and alpha in case of epic/* branches.
During a publish the tag should match the version
There was a problem hiding this comment.
I believe this checks if the version is beta if merged to develop
There was a problem hiding this comment.
Yeah, that's the intention here. If it's the develop branch, it will only publish if the version has beta in it. Additionally, it will append the beta tag to the publish.
If you don't want to publish, then don't make it a beta version.
I did my best to test this on a |
|
Worked for the 
This command give you the |
Description
Problem
Currently, we don't have the ability to publish the CLI plugin to npm unless we merge our code changes to
main. In the case of testing on thedevelopbranch, as well as on epic branches, we don't want to have to merge incomplete changes tomainfor the sake of a publish. It's worth noting that most team members don't have permission to publish directly to the Adobe organization from their local machine, nor do we want to get into the practice of doing so.Additionally, we don't have a dynamic way to add a tag to a publish even if we DID want to merge to main. The current process involves committing the tag in the workflow file and later reverting it. Failure to add the tag results the in publish being tagged as
latestand automatically being installed on the next AIO update (which is bad).Propsal
developbranch will attempt a publish as abetapackagerelease/*branch if we adopt that workflowepic/*branch will attempt a publish as analphapackageCaveat
Opening up publishing from branches other than
maincan be error prone with regard to versioning (we don't want to publish the wrong branch as alatestversion).As such, this PR enforces the following:
package.jsonfile MUST include the appropriate suffix in accordance to the tag it will be published withalpha,beta,latest) depending on the branch the PR was merged toExample
A PR merge to the
epic/cloudflarebranch must be versioned asx.x.x-alpha[.x], and will automatically assume thealphatag when published.Publish to npmstep of the workflow being skipped.How Has This Been Tested?
Manually triggering the workflow.
Additional testing will be performed as the workflow is merged to various branches.
Screenshots (if appropriate):
Checklist: