Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic/secretsmanage #148

Merged
merged 59 commits into from
Jul 12, 2024
Merged

Epic/secretsmanage #148

merged 59 commits into from
Jul 12, 2024

Conversation

AjazSumaiya
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

nvyasadobe and others added 30 commits May 2, 2024 18:50
@nvyasadobe
feat: WIP work in progress, env variables not working in yaml
28446e3
@nvyasadobe
WIP - eod commit - yaml enablement
33c4e74
@nvyasadobe
lint fix
0bd4fc3
@nvyasadobe
Removed static changes in devConsole
f1297e0
@nvyasadobe
update command - secrets management changes
d10d231
@nvyasadobe
tests fix and utils logic changes
bc03ea6
@nvyasadobe
lint fixes
503a6ad
@nvyasadobe
Added secrets validation
8716157
@nvyasadobe
defualt value of secrets set to false
126e9e5
@nvyasadobe
reverted local run command changes as this is not part of this ticket
17cc162
@nvyasadobe
minor revert
a668f84
@nvyasadobe
minor corrections
2181392
@nvyasadobe
Minor changes in messaging
4a41c37
@nvyasadobe
Bumped up version
6884f2b
@amolina-adobe
Merge pull request #134 from adobe/release/3.3.0-edge-mesh
6b93b0b 
CLI updates for Edge Mesh
@nvyasadobe
address review comments + parseEnv config changed to dollar-both
b78d1b3
@nvyasadobe
break parsing into a seperate function
eab4065
@nvyasadobe
WIP - EOD works push
58698c9
@nvyasadobe
Updated function name
030219c
@revanth0212
Merge pull request #135 from adobe/CEXT-3113-secrets-flag-cli
962382c 
CEXT-3113: secrets flag implementation in create and update command
@nvyasadobe
Added tests + todays push
27eb5a9
@nvyasadobe
Merge branch 'epic/secretsmanage' of github.com:adobe/aio-cli-plugin-…
7c03ed0 
…api-mesh into CEXT-3114
@nvyasadobe
Supporting files for tests
3089bbe
@nvyasadobe
Added validations
3966417
@nvyasadobe
Updated regex to restrict in windows + red colour code for errors
2e8d512
@nvyasadobe
added more tests for batch var validation and address changes requested
74cc4e3
@nvyasadobe
lix fixes
9bcd3b3
@nvyasadobe
EOD work
91a84aa
@nvyasadobe
Added test for macOs batch variable validation
137e709
@revanth0212
Merge pull request #137 from adobe/CEXT-3114
49d078b 
Cext 3114
nvyasadobe and others added 19 commits May 22, 2024 20:59
@nvyasadobe
Added try catch
e55597f
@revanth0212
Update src/helpers.js
4fd22bf
@revanth0212
Update src/serverUtils.js
e2d36a7
@revanth0212
Merge pull request #138 from adobe/CEXT-3116-localdev-with-secrets
2ae2576 
CEXT-3116: secrets support for local development.
@nvyasadobe
Created branch from epicSecretsmanage, took pull from main branch so …
aade27b 
…that all latest changes including cloudflare changes can be pulled in
@nvyasadobe
Fixed the tests that were coming due to chalk.bold
4296d6d
@nvyasadobe
lint fix
e842bc6
@revanth0212
Merge pull request #140 from adobe/sync_secrets_epic_branch
efee233 
Sync secrets epic branch
@nvyasadobe
feat: secrets encryption from cli in create and update command. Tests…
af315d3 
… needs to fixed yet
@nvyasadobe
feat: fixed failing tests
8e915fe
@nvyasadobe
Minor changes
42076f8
@nvyasadobe
lint fixes
3fa4f38
@nvyasadobe
Added more tests and some check
6ee9105
@nvyasadobe
Address review comments
254dc6f
@revanth0212
Merge pull request #141 from adobe/secrets-encryption-from-cli
4367252 
Secrets encryption from CLI
@nvyasadobe
Bumped up version for secrets management.
382fa30
@revanth0212
Merge pull request #146 from adobe/version_bump_secretsmanage
fd9f2e3 
Bumped up version for secrets management.
@AjazSumaiya
fix:resolve conflicts
318b2ad
@AjazSumaiya
chore: updated packages
47464fa
revanth0212
revanth0212 previously approved these changes Jul 12, 2024
View reviewed changes
amolina-adobe
amolina-adobe reviewed Jul 12, 2024
View reviewed changes
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@adobe/aio-cli-plugin-api-mesh",
"version": "3.4.0",
"version": "3.5.0-alpha.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend making this 3.5.0-beta.1 so that it will actually publish.

@AjazSumaiya AjazSumaiya marked this pull request as ready for review July 12, 2024 16:13
@AjazSumaiya AjazSumaiya merged commit 2450a4e into develop Jul 12, 2024
3 checks passed
@amolina-adobe amolina-adobe deleted the epic/secretsmanage branch November 21, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolina-adobe amolina-adobe amolina-adobe approved these changes

@revanth0212 revanth0212 revanth0212 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AjazSumaiya @revanth0212 @amolina-adobe @nvyasadobe