Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cext 3315 enable edge cli #159

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Cext 3315 enable edge cli #159

merged 11 commits into from
Aug 9, 2024

Conversation

nvyasadobe
Copy link
Contributor

@nvyasadobe nvyasadobe commented Aug 2, 2024

This PR is to enable edge url for all users.

Description

As part of this PR we will show by default Edge and Legacy both the URLs to all the users. Add appropriate deprecation notice on create, status and describe commands.

Related Issue

https://jira.corp.adobe.com/browse/CEXT-3315

Motivation and Context

Needed for edge enablement.

How Has This Been Tested?

Verified by making a local link of cli plugin.

Screenshots (if appropriate):

(Create Mesh)
image

(Mesh Status)
image

(Describe Mesh)
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvyasadobe nvyasadobe marked this pull request as ready for review August 9, 2024 12:49
amolina-adobe
amolina-adobe previously approved these changes Aug 9, 2024
Copy link
Contributor

@jhadobe jhadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change to the wording and adding the full status command. I did not use any styling to wrap the command, e.g. aio api-mesh status, because I was uncertain of the implications. Please feel free to add styling if available.

src/commands/api-mesh/describe.js Outdated Show resolved Hide resolved
src/commands/api-mesh/__tests__/describe.test.js Outdated Show resolved Hide resolved
src/commands/api-mesh/__tests__/describe.test.js Outdated Show resolved Hide resolved
src/commands/api-mesh/__tests__/describe.test.js Outdated Show resolved Hide resolved
Co-authored-by: Jared Hoover <98363870+jhadobe@users.noreply.github.com>
@amolina-adobe amolina-adobe merged commit b2d93b7 into develop Aug 9, 2024
3 checks passed
@amolina-adobe amolina-adobe deleted the CEXT-3315-enable-edge-cli branch August 9, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants