chore(migration): update merge CGW migration epic branch to develop #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update api_key query param references to x-api-key header
dthampy
previously approved these changes
Oct 21, 2024
revanth0212
reviewed
Oct 22, 2024
| @@ -155,17 +155,18 @@ const getMesh = async (organizationId, projectId, workspaceId, workspaceName, me | |||
| const { baseUrl: devConsoleUrl, accessToken, apiKey } = await getDevConsoleConfig(); | |||
| const config = { | |||
| method: 'get', | |||
| url: `${devConsoleUrl}/organizations/${organizationId}/projects/${projectId}/workspaces/${workspaceId}/meshes/${meshId}?API_KEY=${apiKey}`, | |||
| url: `${devConsoleUrl}/organizations/${organizationId}/projects/${projectId}/workspaces/${workspaceId}/meshes/${meshId}`, | |||
There was a problem hiding this comment.
Did you verify if this works on the dev console API?
revanth0212
approved these changes
Oct 22, 2024
brasewel
reviewed
Oct 22, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@adobe/aio-cli-plugin-api-mesh", | |||
| "version": "3.9.2", | |||
| "version": "3.9.2-beta.1", | |||
There was a problem hiding this comment.
Do we want this to be a beta package?
|
Developer console expects the Api Key to be passed as query parameter in uppercase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
api_keyqueryParam references to be passed asx-api-keyheaderDescription
As part of cluster gateway migration api_key can no longer be passed as a query param and MUST be passed as
x-api-keyheader.Related Issue
https://jira.corp.adobe.com/browse/CEXT-3607
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: