Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): CEXT-3832 - remove legacy mesh references #190

Merged
merged 10 commits into from
Nov 26, 2024

Conversation

amolina-adobe
Copy link
Contributor

@amolina-adobe amolina-adobe commented Nov 19, 2024

Description

Removes all references to the legacy (MGQL) mesh from the CLI plugin command output.

Affects the following commands:

  • create
  • describe
  • status
  • delete

Includes:

  1. removal the legacy mesh url
  2. removal of legacy mesh statuses
  3. removal of any migration notices
  4. removal of api key creation, subscription, and deletion
  5. re-labeling of "Edge mesh" to "Mesh" as it is the sole output
  6. minor updates to various command messaging

Related Issue

https://jira.corp.adobe.com/browse/CEXT-3832

Motivation and Context

Coerce customers to migrate to edge mesh in production, due to complete deprecation of the legacy mesh (MGQL).

How Has This Been Tested?

  • Verified unit tests pass
  • Verified CLI tests pass after updating them to account for new messaging
  • Manual testing of all commands
  • Verified absence or errors in Dev Console UI when creating a mesh with new plugin (without an API Key)
  • Verified rolling back to an old version of the plugin still works with a mesh created the new plugin (without an API Key)

Screenshots (if appropriate):

image

aio api-mesh create

image

aio api-mesh describe

image

aio api-mesh get (for good measure)

image

aio api-mesh status

image image

aio api-mesh update (for good measure)

image

aio api-mesh delete

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@amolina-adobe amolina-adobe marked this pull request as draft November 19, 2024 07:59
@amolina-adobe amolina-adobe force-pushed the cext-3832-remove-legacy-mesh branch from 1cf36f1 to ae57473 Compare November 19, 2024 08:44
src/commands/api-mesh/status.js Outdated Show resolved Hide resolved
src/commands/api-mesh/status.js Outdated Show resolved Hide resolved
src/commands/api-mesh/status.js Outdated Show resolved Hide resolved
src/commands/api-mesh/status.js Outdated Show resolved Hide resolved
src/commands/api-mesh/status.js Outdated Show resolved Hide resolved
src/commands/api-mesh/status.js Outdated Show resolved Hide resolved
@amolina-adobe amolina-adobe force-pushed the cext-3832-remove-legacy-mesh branch from ceadc69 to 013186d Compare November 19, 2024 20:46
@amolina-adobe amolina-adobe changed the base branch from develop to epic/customer-migration November 21, 2024 01:18
@amolina-adobe amolina-adobe marked this pull request as ready for review November 25, 2024 21:11
@amolina-adobe amolina-adobe force-pushed the cext-3832-remove-legacy-mesh branch from 99f8fc6 to 2c01b93 Compare November 25, 2024 22:37
revanth0212
revanth0212 previously approved these changes Nov 26, 2024
kmaschi
kmaschi previously approved these changes Nov 26, 2024
@amolina-adobe amolina-adobe changed the base branch from epic/customer-migration to develop November 26, 2024 15:53
@amolina-adobe amolina-adobe dismissed stale reviews from kmaschi and revanth0212 November 26, 2024 15:53

The base branch was changed.

@amolina-adobe amolina-adobe merged commit a99c395 into develop Nov 26, 2024
4 checks passed
@amolina-adobe amolina-adobe deleted the cext-3832-remove-legacy-mesh branch November 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants