fix: daily.yml npm install and test (#503)

adobe · Dec 9, 2021 · e28ea5d · e28ea5d
1 parent 008f8b2
commit e28ea5d
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 28 deletions.
diff --git a/package.json b/package.json
@@ -44,23 +44,24 @@
   },
   "devDependencies": {
     "@adobe/aio-lib-test-proxy": "^1.0.0",
-    "@adobe/eslint-config-aio-lib-config": "^1.3.0",
+    "@adobe/eslint-config-aio-lib-config": "^1.4.0",
     "@oclif/dev-cli": "^1.21.3",
     "@types/jest": "^26.0.10",
     "babel-runtime": "^6.26.0",
     "codecov": "^3.6.1",
     "eol": "^0.9.1",
-    "eslint": "^6.0.0",
-    "eslint-config-standard": "^14.1.1",
-    "eslint-plugin-import": "^2.20.2",
-    "eslint-plugin-jest": "^23.13.0",
-    "eslint-plugin-jsdoc": "^25.0.0",
-    "eslint-plugin-node": "^10.0.0",
-    "eslint-plugin-promise": "^4.2.1",
+    "eslint": "^7.32.0",
+    "eslint-config-standard": "^16.0.3",
+    "eslint-plugin-import": "^2.25.3",
+    "eslint-plugin-jest": "^23.20.0",
+    "eslint-plugin-jsdoc": "^37.1.0",
+    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-promise": "^5.2.0",
     "eslint-plugin-standard": "^4.0.1",
     "jest": "^26.6.3",
     "jest-plugin-fs": "^2.9.0",
-    "stdout-stderr": "^0.1.9"
+    "stdout-stderr": "^0.1.9",
+    "typescript": "^4.5.2"
   },
   "engineStrict": true,
   "engines": {

diff --git a/src/commands/app/deploy.js b/src/commands/app/deploy.js
@@ -84,12 +84,14 @@ class Deploy extends BuildCommand {
   }
 
   async deploySingleConfig (name, config, flags, spinner) {
-    const onProgress = !flags.verbose ? info => {
-      spinner.text = info
-    } : info => {
-      spinner.info(chalk.dim(`${info}`))
-      spinner.start()
-    }
+    const onProgress = !flags.verbose
+      ? info => {
+        spinner.text = info
+      }
+      : info => {
+        spinner.info(chalk.dim(`${info}`))
+        spinner.start()
+      }
 
     // build phase
     if (flags.build) {

diff --git a/src/commands/app/run.js b/src/commands/app/run.js
@@ -97,12 +97,14 @@ class Run extends BaseCommand {
       }
     }
 
-    const onProgress = !flags.verbose ? info => {
-      spinner.text = info
-    } : info => {
-      spinner.info(chalk.dim(`${info}`))
-      spinner.start()
-    }
+    const onProgress = !flags.verbose
+      ? info => {
+        spinner.text = info
+      }
+      : info => {
+        spinner.info(chalk.dim(`${info}`))
+        spinner.start()
+      }
 
     const frontendUrl = await runDev(config, this.config.dataDir, runOptions, onProgress)
     try {

diff --git a/src/commands/app/undeploy.js b/src/commands/app/undeploy.js
@@ -72,12 +72,14 @@ class Undeploy extends BaseCommand {
   }
 
   async undeployOneExt (extName, config, flags, spinner) {
-    const onProgress = !flags.verbose ? info => {
-      spinner.text = info
-    } : info => {
-      spinner.info(chalk.dim(`${info}`))
-      spinner.start()
-    }
+    const onProgress = !flags.verbose
+      ? info => {
+        spinner.text = info
+      }
+      : info => {
+        spinner.info(chalk.dim(`${info}`))
+        spinner.start()
+      }
     // undeploy
     try {
       await runScript(config.hooks['pre-app-undeploy'])

diff --git a/src/lib/deploy-actions.js b/src/lib/deploy-actions.js
@@ -17,7 +17,7 @@ const { deployActions } = require('@adobe/aio-lib-runtime')
  * Deploys actions.
  *
  * @param {object} config see src/lib/config-loader.js
- * @param {boolean} isLocal=false set to true if it's a local deploy
+ * @param {boolean} isLocal default false, set to true if it's a local deploy
  * @param {Function} [log] a log function
  * @param {boolean} filter true if a filter by built actions is desired.
  */