Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new app event hooks for custom build scripts #339

Closed
shazron opened this issue Dec 3, 2020 · 2 comments · Fixed by #340
Closed

feat: add new app event hooks for custom build scripts #339

shazron opened this issue Dec 3, 2020 · 2 comments · Fixed by #340
Labels
enhancement New feature or request

Comments

@shazron
Copy link
Member

shazron commented Dec 3, 2020

The current event hooks are defined at https://www.adobe.io/apis/experienceplatform/project-firefly/docs.html#!AdobeDocs/project-firefly/master/guides/app-hooks.md

These are the current list of 6 hooks. Note that they do not apply to all commands, only some (for example, deploy hooks don't apply to aio app run):

1. pre-app-run
2. pre-app-build
3. post-app-build
4. pre-app-deploy
5. post-app-deploy
6. post-app-run

The new list would contain 4 new hooks, and would apply to all applicable commands:

1. pre-app-run
2. pre-app-build
3. build-actions (replaces default tooling if present)
4. build-static (replaces default tooling if present)
5. post-app-build
6. pre-app-deploy
7. deploy-actions (replaces default tooling if present)
8. deploy-static (replaces default tooling if present)
9. post-app-deploy
10. post-app-run

Motivation

There are some apps that need to customize:

  1. how the static files are being built (custom webpack for example)
  2. how the actions are being built (package all static files in a folder with the action without needing to specify as include in manifest.yml for example -- to include template files for serving up later)
@shazron shazron added the enhancement New feature or request label Dec 3, 2020
@aiojbot
Copy link
Collaborator

aiojbot commented Dec 3, 2020

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-976

@shazron
Copy link
Member Author

shazron commented Dec 3, 2020

PR #340

@shazron shazron mentioned this issue Dec 4, 2020
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants