-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom webpack configuration for bundling actions #344
Comments
Thanks @rajarju ! Let's discuss about it this week. |
JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-981 |
@meryllblanchet I wonder if exposing the webpack config is still necessary now that we have new hooks to build actions AdobeDocs/app-builder#83 |
@icaraps there could be use-cases for which the whole config has to be changed, specifically for a single action or a sub-group of actions within an app. I feel like using WDYT? |
@meryllblanchet I'd pick 2-3 use cases and compare both solutions (hook vs custom webpack config) to identify pros and cons wdyt ? |
The handlebar use case came up during the hackathon. Devs wanted to bundle Including assets like images is another case. IMO it would still be useful to have ways to configure each action. :) |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When deploying actions
aio app
plugin bundles the actions with a pre-defined webpack config.I would like to include some additional files, like handlebar templates or jsx components as part of the package.
This is not possible as the bundler doesn't like anything other than js files and I am not able to configure it with a webpack config file.
Describe the solution you'd like
The app plugin when bundling can look for a
webpack
config file under the action directoryaction
directory will be used when bundling the current actionactions
directory will be used to bundle all actionsThe values in the custom webpack config will be used to override the standard
aio app
bundle configDescribe alternatives you've considered
A workaround is to run a custom bundler to compile/convert your files to js and add them to the actions directory
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: