Configurable webpack - rebase

[purplecabbage]

Description

Configurable webpack

• re-added implementation, tests, and fixtures
• replaces, closes Configurable webpack #19

Search action path for *webpack-config.js
search order is:

1. /app-root/actions/actionname/
2. /app-root/actions/
3. /app-root/

Merge webpack config to include required props :

• entry [actionPath, ...]
• output { path, filename, ... }
• resolve.extensions [.js, .json, ... ]
• resolve.mainFields [ main, ... ]

Related Issue

• Allow custom webpack configuration for bundling actions aio-cli-plugin-app#344

• Using npm module (inline-css) in global packages.json leads to error in webpack #30

• lighthouse dependency is not working properly in aio-cli aio-cli-plugin-app#196

Motivation and Context

extensible everything

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #31 (5ccf3da) into master (0356ac0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          992      1038   +46     
  Branches       242       256   +14     
=========================================
+ Hits           992      1038   +46     

Impacted Files	Coverage Δ
src/build-actions.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0356ac0...242ddd4. Read the comment docs.

[shazron]

There are warnings regarding "Assignment to function parameter 'filterActions'"
and also JSDoc warnings

[moritzraho]

apart from eslint warnings, code lgtm, will do some testing now

[moritzraho]

I see two things which are required to compile some of our sdks that should be further enforced:

• libraryTarget: 'commonjs2', if config.output = {}, libraryTarget will get overwritten
• minimize: false, if config.optimizations ={}, minimize: false will get overwritten

I think those two should be overwritten only if explicitly set by the user.

[moritzraho]

All good on my side now!
@purplecabbage feel free to give it a last review and merge

Here is a summary of my manual testing:

Setup:

• new app with 5 actions (including asset-compute)

Flow:

• test commands:
  • DEBUG=@adobe/aio-lib-runtime:action-builder* aio app build --skip-static
  • DEBUG=@adobe/aio-lib-runtime:action-builder* aio app run --skip-static
• look at logs:
  • make sure the action builds
  • the config is the one expected
• can invoke the action when applicable

Variations

• no config file
• using a full webpack-config.js in root only => make sure it's picked up
• adding a different webpack-config.js in actions folder => make sure this is the one picked up
• adding yet a different in specific actions
• set entry files with relative paths to the config file
• make sure there are no duplicates in config
• custom package name (no __APP_PACKAGE__)
• 2 packages