Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio app run: re-factor so new app hooks can be added easily #345

Closed
shazron opened this issue Dec 7, 2020 · 2 comments · Fixed by #343
Closed

aio app run: re-factor so new app hooks can be added easily #345

shazron opened this issue Dec 7, 2020 · 2 comments · Fixed by #343
Assignees
@Himavanth
Labels
bug Something isn't working

Comments

@shazron
Copy link
Member

shazron commented Dec 7, 2020

For #340 new app hooks have been added to substitute the build and deploy steps for actions and web assets.
The aio app run command should support these new app hooks, but it needs to re-factor so they can be added easily.

aio app run does build the actions and web-assets so these hooks should work:

  1. build-actions
  2. build-static

aio app run only deploys actions, and not the web assets -- these are served locally via a web server. Only this hook should work:

  1. deploy-actions
@shazron shazron added the bug Something isn't working label Dec 7, 2020
@shazron
Copy link
Member Author

shazron commented Dec 7, 2020

PR #343

This was referenced Dec 7, 2020
Closed
Merged
@aiojbot
Copy link
Collaborator

aiojbot commented Dec 7, 2020

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Himavanth Himavanth

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modularization of app run adobe/aio-cli-plugin-app
3 participants
@shazron @Himavanth @aiojbot