You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When a we fire an oclif hook event it is handled by one or more cli plugin hook responder. If any of these hook responders encounters an error, it cannot exit the app and any exception it throws is quietly caught deep in oclif.
All OclifCommand calls to this.config.runHook('hook-id', <context-data>) are await-able, and return an object with 2 arrays, {failures[], successes[]}
We need to read failures and exit if appropriate.
To Reproduce
Steps to reproduce the behavior:
write a hook responder that gets called
throw an error from your hook responder
observe that the cli command continues as if nothing happened
Expected behavior
clear log message identifying the plugin where the error occurred
clear log message identifying what went wrong and how to correct it
The text was updated successfully, but these errors were encountered:
Describe the bug
When a we fire an oclif hook event it is handled by one or more cli plugin hook responder. If any of these hook responders encounters an error, it cannot exit the app and any exception it throws is quietly caught deep in oclif.
All OclifCommand calls to
this.config.runHook('hook-id', <context-data>)
are await-able, and return an object with 2 arrays,{failures[], successes[]}
We need to read failures and exit if appropriate.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The text was updated successfully, but these errors were encountered: