Hook errors#665 #666
Merged
Hook errors#665 #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 2840 2849 +9
Branches 534 538 +4
=========================================
+ Hits 2840 2849 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shazron
reviewed
May 3, 2023
| const hookResults = await this.config.runHook('pre-deploy-event-reg', { appConfig: config }) | ||
| if (hookResults?.failures?.length > 0) { | ||
| // output should be "Error : <plugin-name> : <error-message>\n" for each failure | ||
| this.error(hookResults.failures.map(f => `${f.plugin.name} : ${f.error.message}`).join('\nError: '), { exit: 1 }) |
There was a problem hiding this comment.
Do we want to extract this into a function in the class? Since it is duplicated thrice
There was a problem hiding this comment.
its not exactly the same all 3 times
if we need to write it 5 times I'll consider it, or if it expands into more than 1 line.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #665
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: