Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import library for downloadable config #116

Merged
merged 7 commits into from
Jan 8, 2020
Merged

feat: import library for downloadable config #116

merged 7 commits into from
Jan 8, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 7, 2020

Description

Import library for the downloadable config from Adobe I/O Console. To be used with the app:use and app:create commands, via the --import flag.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Full coverage of tests pending.
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #116 into master will increase coverage by 1.67%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage    87.4%   89.07%   +1.67%     
==========================================
  Files          10       11       +1     
  Lines         254      293      +39     
  Branches       37       39       +2     
==========================================
+ Hits          222      261      +39     
  Misses         28       28              
  Partials        4        4
Impacted Files Coverage Δ
src/lib/import.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e5bde...948a24e. Read the comment docs.

@shazron
Copy link
Member Author

shazron commented Jan 8, 2020

todo: need to encode any key names that have underscores with double underscores

@shazron shazron marked this pull request as ready for review January 8, 2020 07:17
@shazron shazron merged commit bb403e6 into master Jan 8, 2020
@shazron shazron deleted the ACNA-613 branch January 8, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant