ACNA-621 - init --import #133
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 18 18
Lines 466 466
Branches 56 56
=======================================
Hits 456 456
Misses 10 10Continue to review full report at Codecov.
|
|
@shazron or @purplecabbage ready to review! |
| if (flags.import) { | ||
| const config = loadConfigFile(flags.import).values | ||
|
|
||
| projectName = config.name // must be defined |
There was a problem hiding this comment.
There is some weirdness here ...
If I specify a project path as an arg to init, then the directory is created, and becomes cwd.
If a config file is used, then the project name comes from there, but no directory is created, and project is placed in cwd.
Ultimately this is probably just something we need to document..
| expect(TheCommand.flags.import.char).toBe('i') | ||
| }) | ||
|
|
||
| test('args', async () => { |
There was a problem hiding this comment.
We previously removed tests that were this tightly tied to the implementation.
Test should only verify that arg has description, and default, but not what the values actually are.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: