Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display action urls on deployment & run #160

Merged
merged 4 commits into from
Mar 9, 2020

Conversation

moritzraho
Copy link
Member

To be merged after adobe/aio-lib-web#81
and after https://github.com/adobe/aio-app-scripts is released

Description

fixes #91

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #160 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   93.81%   93.89%   +0.07%     
==========================================
  Files          20       20              
  Lines         566      573       +7     
  Branches       68       71       +3     
==========================================
+ Hits          531      538       +7     
  Misses         31       31              
  Partials        4        4              
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedba55...ca24088. Read the comment docs.

@moritzraho
Copy link
Member Author

moritzraho commented Feb 19, 2020

@purplecabbage @sandeep-paliwal any of you has time for review?

Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moritzraho
Copy link
Member Author

LGTM

Thanks ! When you get the chance (no rush) could you also review adobe/aio-lib-web#81 ?

@OmarEltobgy
Copy link

@moritzraho Can you please tell me when this PR is expected to be merged ?
We have been waiting for it so that we can use it in our CI/CD pipeline.

@moritzraho moritzraho merged commit 280e1db into adobe:master Mar 9, 2020
@moritzraho moritzraho deleted the show-action-urls branch March 9, 2020 10:38
@moritzraho
Copy link
Member Author

@OmarEltobgy merged, will release a new version in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show action urls in run and deploy output
4 participants