-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support having actions at any folder level #169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 20 20
Lines 563 563
Branches 67 67
=======================================
Hits 528 528
Misses 31 31
Partials 4 4
Continue to review full report at Codecov.
|
Hi @tmathern, would it be ok for you to change the condition from has actions/ folder to has ./manifest.yml file instead of removing it? we would like to still support @sandeep-paliwal is currently implementing the UI only case and checks backend existance by checking the manifest.yml file see https://github.com/adobe/aio-app-scripts/pull/80/files#diff-59e86d77d535d34e7d6039470196fc03R118 |
@moritzraho Makes sense. |
@moritzraho Ack. I updated the PR to rely on manifest.yml for deployment. |
thanks @tmathern! merging the PR |
Check for manifest presence.
Check for manifest presence to support having deployable actions at any folder level.
#168
Also, NUI-246.
Motivation and Context
Nui needs this to deploy.
How Has This Been Tested?
Updated unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: