Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support having actions at any folder level #169

Merged
merged 7 commits into from
Mar 9, 2020
Merged

Support having actions at any folder level #169

merged 7 commits into from
Mar 9, 2020

Conversation

tmathern
Copy link
Member

@tmathern tmathern commented Mar 5, 2020

Check for manifest presence.

Check for manifest presence to support having deployable actions at any folder level.

#168
Also, NUI-246.

Motivation and Context

Nui needs this to deploy.

How Has This Been Tested?

Updated unit tests.

Screenshots (if appropriate):

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@tmathern tmathern marked this pull request as ready for review March 5, 2020 17:02
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files          20       20           
  Lines         563      563           
  Branches       67       67           
=======================================
  Hits          528      528           
  Misses         31       31           
  Partials        4        4
Impacted Files Coverage Δ
src/commands/app/deploy.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d2024...480efc6. Read the comment docs.

@moritzraho
Copy link
Member

moritzraho commented Mar 6, 2020

Hi @tmathern,

would it be ok for you to change the condition from has actions/ folder to has ./manifest.yml file instead of removing it?

we would like to still support aio app deploy even if there is no backend/frontend by skipping the build/deployment

@sandeep-paliwal is currently implementing the UI only case and checks backend existance by checking the manifest.yml file see https://github.com/adobe/aio-app-scripts/pull/80/files#diff-59e86d77d535d34e7d6039470196fc03R118

@alexkli
Copy link

alexkli commented Mar 6, 2020

@moritzraho Makes sense.

@tmathern
Copy link
Member Author

tmathern commented Mar 6, 2020

@moritzraho Ack. I updated the PR to rely on manifest.yml for deployment.

@moritzraho
Copy link
Member

thanks @tmathern! merging the PR

@moritzraho moritzraho merged commit 934783f into adobe:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants