Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align undeploy flags with deploy command #172

Merged
merged 5 commits into from
Mar 9, 2020

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Mar 9, 2020

see #156

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #172 into master will decrease coverage by 1.71%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   93.89%   92.17%   -1.72%     
==========================================
  Files          20       20              
  Lines         573      575       +2     
  Branches       71       72       +1     
==========================================
- Hits          538      530       -8     
- Misses         31       40       +9     
- Partials        4        5       +1
Impacted Files Coverage Δ
src/commands/app/undeploy.js 72.97% <100%> (-27.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280e1db...19f2b29. Read the comment docs.

@moritzraho moritzraho merged commit 6cd61db into adobe:master Mar 9, 2020
@moritzraho moritzraho deleted the flags-undeploy branch March 9, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant