Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downloadable Config - org name, and credential names can have spaces #199

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented Apr 28, 2020

Closes #197

How Has This Been Tested?

npm test
# init
aio app:init Foo1 --import my.valid.config.json
# select defaults in Yeoman
cd Foo1
aio config --local
aio config --env

# create
aio app:create Foo2 --import my.valid.config.json
cd Foo2
aio config --local
aio config --env

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #199   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          624       625    +1     
  Branches        79        79           
=========================================
+ Hits           624       625    +1     
Impacted Files Coverage Δ
src/lib/import.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee514d2...019113e. Read the comment docs.

@shazron shazron merged commit 6a6a314 into master Apr 28, 2020
@shazron shazron deleted the names-with-spaces branch April 28, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloadable Config - org name, and credential names can have spaces
1 participant