Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tail log #207

Merged
merged 14 commits into from
May 13, 2020
Merged

Enable Tail log #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9f85aa1
Merge pull request #1 from adobe/master
sandeep-paliwal Nov 4, 2019
5be67fc
Merge pull request #2 from adobe/master
sandeep-paliwal Nov 5, 2019
7c14a16
Merge pull request #3 from adobe/master
sandeep-paliwal Nov 12, 2019
5ddce7f
Merge pull request #4 from adobe/master
sandeep-paliwal Nov 25, 2019
d0ee425
Merge pull request #5 from adobe/master
sandeep-paliwal Jan 6, 2020
22a537e
Merge pull request #6 from adobe/master
sandeep-paliwal Jan 27, 2020
a82b4c0
Merge pull request #7 from adobe/master
sandeep-paliwal Feb 7, 2020
03fb53f
Merge pull request #8 from adobe/master
sandeep-paliwal Feb 10, 2020
f35d155
Merge pull request #9 from adobe/master
sandeep-paliwal Mar 6, 2020
d2e79d1
Merge pull request #10 from adobe/master
sandeep-paliwal Apr 9, 2020
6623b8c
Merge pull request #11 from adobe/master
sandeep-paliwal Apr 29, 2020
6add52e
Merge pull request #12 from adobe/master
sandeep-paliwal May 12, 2020
9882a99
Enable fetching logs for aio app run command
sandeep-paliwal May 12, 2020
dffa328
Added test to check if fetchLogs flag is always set when calling scri…
sandeep-paliwal May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/commands/app/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ class Run extends BaseCommand {
skipActions: !!flags['skip-actions'],
parcel: {
logLevel: flags.verbose ? 4 : 2
}
},
fetchLogs: true
}

try {
Expand Down
8 changes: 8 additions & 0 deletions test/commands/app/run.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,14 @@ describe('run', () => {
}))
})

test('app:run check if fetchLogs flag is set when calling scripts', async () => {
mockFSExists(['web-src/', 'manifest.yml', PRIVATE_KEY_PATH, PUB_CERT_PATH])
await RunCommand.run([])
expect(mockScripts.runDev).toHaveBeenCalledWith([], expect.objectContaining({
fetchLogs: true
}))
})

test('app:run with -verbose', async () => {
mockFSExists(['web-src/', 'manifest.yml', PRIVATE_KEY_PATH, PUB_CERT_PATH])
await RunCommand.run(['--verbose'])
Expand Down