Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add mergeEnv, splitEnvLine tests #223

Merged
merged 2 commits into from
May 16, 2020
Merged

fix: add mergeEnv, splitEnvLine tests #223

merged 2 commits into from
May 16, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented May 16, 2020

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron requested a review from purplecabbage May 16, 2020 04:24
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #223 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #223   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          673       682    +9     
  Branches        85        86    +1     
=========================================
+ Hits           673       682    +9     
Impacted Files Coverage Δ
src/lib/import.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c65074...518edb7. Read the comment docs.

@shazron shazron merged commit 4c351ab into master May 16, 2020
@shazron shazron deleted the merge-env-tests branch May 16, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant