Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overly restrictive organization pattern #232

Merged
merged 2 commits into from
May 18, 2020
Merged

fix: overly restrictive organization pattern #232

merged 2 commits into from
May 18, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented May 18, 2020

Closes #230

IMS organization can be anything in Unicode BMP with a max of 255 characters.
The regex prevents leading or trailing whitespace characters.
Test on 5 chars max: https://regex101.com/r/IX4PYF/1

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meryllblanchet meryllblanchet requested a review from moritzraho May 18, 2020 08:28
@shazron
Copy link
Member Author

shazron commented May 18, 2020

codecov is down: https://status.codecov.io/
this PR builds and an admin can merge it regardless.

@moritzraho
Copy link
Member

lgtm

@shazron shazron merged commit c8abd43 into master May 18, 2020
@shazron shazron deleted the issue-230 branch May 18, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overly Restrictive Organization Pattern
2 participants