Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open flag will open default browser #247

Merged
merged 4 commits into from
May 29, 2020

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented May 29, 2020

Description

Use --open flag to open default browser after successful run/deploy

Related Issue

Closes #157

Motivation and Context

using '--open' is consistent with other tools

parcel serve --open
ng serve --open
webpack-dev-server --open 
npx http-server [path] --open
...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #247 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          766       773    +7     
  Branches       104       106    +2     
=========================================
+ Hits           766       773    +7     
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)
src/commands/app/run.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4309df8...13fb011. Read the comment docs.

@purplecabbage purplecabbage merged commit a69390a into adobe:master May 29, 2020
@purplecabbage purplecabbage deleted the launch-flags branch May 29, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants