Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag --login/--no-login to skip console-generator #248

Merged
merged 3 commits into from
May 29, 2020

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented May 29, 2020

Description

Add flag --login/--no-login to skip console-generator

Related Issue

Closes #241

Motivation and Context

There might be times where you could start a project in a disconnected state, and later add config to the project, currently users without an adobe id to login have to wait 2 minutes for the timeout.

How Has This Been Tested?

Manually, and with tests ...

Screenshots (if appropriate):

🔥🐝 aio app init --no-login  
...
? Which type of sample actions do you want to create?
select type of actions to generate (Press <space> to select, <a> to toggle all, <i> to invert sel
ection)
❯◯ Adobe Target
 ◯ Adobe Analytics
 ◯ Adobe Campaign Standard
 ◯ Adobe Experience Platform: Realtime Customer Profile
 ◯ Adobe Audience Manager: Customer Data
 ◉ Generic

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          766       766           
  Branches       104       104           
=========================================
  Hits           766       766           
Impacted Files Coverage Δ
src/commands/app/init.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f97144...607c3fb. Read the comment docs.

@purplecabbage purplecabbage merged commit 4309df8 into adobe:master May 29, 2020
@purplecabbage purplecabbage deleted the #241 branch May 29, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio app init - users without an Adobe ID - quick way to proceed
3 participants