Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep a reference to the credentials in the config #253

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Jun 2, 2020

Description

Currently there is no way to know if the credentials belong to the workspace or not and what is the integration id.
This PR adds the credentials reference and id into the workspace config so that the credentials can be retrieved from the .env using that key

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          773       775    +2     
  Branches       106       106           
=========================================
+ Hits           773       775    +2     
Impacted Files Coverage Δ
src/lib/import.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348f3ea...60c7452. Read the comment docs.

@moritzraho moritzraho requested a review from shazron June 2, 2020 16:48
@shazron shazron changed the title keep a reference to the credentials in the config feat: keep a reference to the credentials in the config Jun 3, 2020
@moritzraho moritzraho merged commit 21a3ed6 into adobe:master Jun 9, 2020
@moritzraho moritzraho deleted the reference-credentials-config branch June 9, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants