Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename $<config> to <config> #265

Merged
merged 6 commits into from
Jul 6, 2020
Merged

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Jun 23, 2020

Relates to adobe/aio-cli#191
Depends on adobe/aio-lib-ims#48
Relates to adobe/aio-lib-ims#47

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          797       797           
  Branches       107       107           
=========================================
  Hits           797       797           
Impacted Files Coverage Δ
src/lib/import.js 100.00% <ø> (ø)
src/lib/app-helper.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd4330...6f1a988. Read the comment docs.

@moritzraho moritzraho changed the title rename $ims to ims rename $<config> to <config> Jun 24, 2020
@moritzraho moritzraho marked this pull request as draft June 29, 2020 12:55
@moritzraho moritzraho requested a review from shazron July 3, 2020 15:04
@moritzraho moritzraho marked this pull request as ready for review July 3, 2020 15:05
package.json Outdated Show resolved Hide resolved
test/commands/lib/import.test.js Outdated Show resolved Hide resolved
@moritzraho moritzraho merged commit ba4a08e into adobe:master Jul 6, 2020
@moritzraho moritzraho deleted the rename-ims-config branch July 6, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants