Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-942 - Windows: docker not found when running aio app run --local --verbose (openwhisk) #318

Merged
merged 6 commits into from
Nov 9, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 5, 2020

Two changes:

  1. The OpenWhisk jar URL has been updated to include the Windows Docker fix: https://github.com/adobe/openwhisk/releases/tag/standalone-v1
  2. The OpenWhisk jar is not downloaded into the aio-cli-plugin-app's bin folder anymore, but in the cli's dataDir folder as specified in the oclif config. On macOS, this location for @adobe/aio-cli is ~/.local/share/@adobe/aio-cli/openwhisk/openwhisk-standalone.jar. This is so the .jar is not deleted on every app plugin update.

How Has This Been Tested?

npm test
aio app run --local --verbose

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov

This comment has been minimized.

@shazron shazron closed this Nov 5, 2020
@shazron shazron reopened this Nov 5, 2020
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 inline comments

src/BaseCommand.js Outdated Show resolved Hide resolved
src/lib/runDev.js Outdated Show resolved Hide resolved
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes, lgtm

@shazron shazron merged commit 7b1e73a into master Nov 9, 2020
@shazron shazron deleted the ow-jar branch November 9, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants